Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional vgpu validations #77

Merged
merged 1 commit into from
May 13, 2024

Conversation

ibrokethecloud
Copy link
Collaborator

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

PR introduces additional vgpu validation to handle scnearios where

  • empty vGPUTypeName is passed when enabling a vGPU device
  • an invalid vGPUTypeName is passed when enabling a vGPU device

Solution:

Related Issue:
harvester/harvester#5775

Test plan:

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@WebberHuang1118 WebberHuang1118 merged commit bc3f57a into harvester:master May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants